Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak release shell scripts and publishing docs #589

Merged
merged 4 commits into from
Mar 16, 2018
Merged

Tweak release shell scripts and publishing docs #589

merged 4 commits into from
Mar 16, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Mar 8, 2018 •
edited
Loading

Tweaks to the script and publishing docs wording based on Nick's feedback when going through the release steps.

  • Update documentation and smaller marked steps
  • Update npm-publish script to more accurately check if package doesn't yet exist
  • Update script that checks and creates package.json with updated wording and whitespace removal from the created package.json
  • Update CHANGELOG

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 13:46 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 778e1aa to a574aa4 Compare March 8, 2018 13:55
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 13:55 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from a574aa4 to 6032e19 Compare March 8, 2018 14:12
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 14:12 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 6032e19 to d01e45c Compare March 8, 2018 14:59
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 14:59 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from d01e45c to eaa3e7d Compare March 8, 2018 16:23
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:23 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from eaa3e7d to 92ae309 Compare March 8, 2018 16:28
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:28 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 92ae309 to 5155123 Compare March 8, 2018 16:32
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:32 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 5155123 to 5cdb5e8 Compare March 8, 2018 16:33
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:33 Inactive
@kr8n3r kr8n3r changed the title Tweak check-and-create-package-json shell script and publishing docs Tweak release shell script and publishing docs Mar 8, 2018
@kr8n3r kr8n3r changed the title Tweak release shell script and publishing docs Tweak release shell scripts and publishing docs Mar 8, 2018
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:41 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from eb8fc6f to 1dde140 Compare March 8, 2018 16:43
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 16:43 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 1dde140 to dc7228b Compare March 8, 2018 21:02
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 21:02 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from dc7228b to 855d1ec Compare March 8, 2018 21:02
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 21:03 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 855d1ec to 85f6941 Compare March 8, 2018 21:09
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-589 March 8, 2018 21:09 Inactive
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 85f6941 to 535c882 Compare March 8, 2018 21:50
alex-ju
alex-ju approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@alex-ju alex-ju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

Left two non-blocking comments.
Needs rebase for CHANGELOG.

bin/npm-publish.sh Outdated
echo "🗒 Package published!"
else
echo "⚠️ $PACKAGE@$VERSION is already published!"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have a new line at the end of file.

docs/publishing.md

You can use `npm whoami` to check your current user.
16. Add Trello cards to "This Sprint" column for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this step, I see it more as part of our release plan/process rather than the publishing process.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving it there for now until there is a better home

Update check-json script to add version
b1d5e9b 
Also update wording on the prompt to clearly indicate
what needs to me amended
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 535c882 to 3703c07 Compare March 16, 2018 11:32
@kr8n3r kr8n3r force-pushed the update-check-json-script branch from 3703c07 to 47a862c Compare March 16, 2018 11:33
@kr8n3r kr8n3r merged commit 79d1d99 into master Mar 16, 2018
@kr8n3r kr8n3r deleted the update-check-json-script branch March 16, 2018 11:37
@hannalaakso hannalaakso mentioned this pull request Apr 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kr8n3r @alex-ju @govuk-design-system-ci