Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review app - Use layout wrappers and add back links #603

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Review app - Use layout wrappers and add back links #603

merged 1 commit into from
Mar 13, 2018

Conversation

dashouse
Copy link

  • use our layout wrappers in the review app
  • add back links on example pages
  • update some headings for consistency

kr8n3r
kr8n3r approved these changes Mar 13, 2018
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dashouse dashouse merged commit 1a63170 into master Mar 13, 2018
@dashouse dashouse deleted the update-layouts-to-use-our-layout branch March 13, 2018 16:22
@36degrees
Copy link
Contributor

I am seeing some funky behaviour with the example iframes as a result of this change (I think…)

screen shot 2018-03-14 at 09 32 15

screen shot 2018-03-14 at 09 33 08

screen shot 2018-03-14 at 09 33 12

@dashouse
Copy link
Author

dashouse commented Mar 14, 2018 •
edited
Loading

Damn...

I removed the inline style body { margin: 15px } but it didn't look like this on my branch locally.

@dashouse
Copy link
Author

dashouse commented Mar 14, 2018 •
edited
Loading

Fix - #605

@dashouse dashouse mentioned this pull request Mar 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dashouse @36degrees @kr8n3r @govuk-design-system-ci