Listen for development server on different port for tests #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
dabe6f8 to
864c3da
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
864c3da to
c31ea93
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
|
do you also need to change the heroku script in package.json? |
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
c31ea93 to
d294ee8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
d294ee8 to
f214d4d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
f214d4d to
02bfb3d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
02bfb3d to
d62c8e3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
|
could we have |
|
I don't like using globals in Node.js projects, so tried that but it felt over-the-top, this repeats it but requires less thinking to understand the code. Happy to put it back in though |
|
don't forget the changelog as well |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
80140af to
541f483
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
541f483 to
e41e605
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-622
Required some refactoring of how we listen since the tests were not actually, adding a new listener. Fixes issues with tests not closing properly by allowing tests to turn off nunjucks watch mode. Used https://github.com/mafintosh/why-is-node-running to identify and fix this issue.
NickColley
force-pushed
the
fix-tests-colliding-with-dev-server
branch
from
e41e605 to
145c7c6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required some refactoring of how we listen since the tests were not actually,
adding a new listener.
Also fixes issues with tests not closing properly by allowing tests to turn off
nunjucks watch mode.
Used https://github.com/mafintosh/why-is-node-running to identify and fix this issue.
Use https://github.com/alphagov/govuk-frontend/pull/622/files?w=1 to see changes without whitespace updates, since I've indented a lot of code.
Fixes #612