Section break styles fix when used with Elements #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
kr8n3r
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
NickColley
reviewed
May 8, 2018
src/globals/core/_section-break.scss
Outdated
| @@ -44,6 +44,9 @@ | |||
|
|
|||
| %govuk-section-break--visible { | |||
| border-bottom: 1px solid $govuk-border-colour; | |||
| @include govuk-compatibility(govuk_elements) { | |||
There was a problem hiding this comment.
What happens when elements overrides the invisible break?
There was a problem hiding this comment.
me being stupid and not moving it into where i said i was. fixed now.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-682
NickColley
reviewed
May 8, 2018
src/globals/core/_section-break.scss
Outdated
| @@ -5,6 +5,12 @@ | |||
| %govuk-section-break { | |||
| margin: 0; | |||
| border: 0; | |||
|
|
|||
| // fix doouble-width section break and forced visible section break | |||
added 2 commits
May 8, 2018 14:09
`<hr>` styling in Elements has background and height set, whereas in Frontend we're using border bottom. To fix, `height:0` was added in a compatibility conditional include.
NickColley
approved these changes
May 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<hr>styling in Elements has background and heightset, whereas in Frontend we're using border bottom.
To fix,
height:0was added in a compatibility conditional include.This fixes both the thickness and the fact that styles from Elements were making invisible section breaks visible
Before:
After:
Elements styles causing non-visible section break to be visible:
Ticket: https://trello.com/c/Sc7RtFZK/815-remove-section-break-border-coming-from-elements