Add option to set CSS display property to govuk-shape-arrow mixin #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-701
kr8n3r
changed the title
govuk-shape-arrow mixin
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-701
Merged
kr8n3r
force-pushed
the
update-shape-mixin
branch
from
162a7b9 to
419178a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-701
kr8n3r
force-pushed
the
update-shape-mixin
branch
from
419178a to
12a90ca
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-701
Default set to display:block
kr8n3r
force-pushed
the
update-shape-mixin
branch
from
12a90ca to
2a1f0e7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixin had
display:blockset, but in the header component work, we need to set it asdisplay:inline-blockTo avoid duplicating properties, this PR allows the display property to be passed to the arrow mixin while setting
display:blockas default.Fixes: #698
Note to reviewers: Amend, update or merge on my behalf on Monday