Add inset text component #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
alex-ju
force-pushed
the
add-inset-text-component
branch
from
f6aee96 to
b2de8f9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
alex-ju
force-pushed
the
add-inset-text-component
branch
from
b2de8f9 to
ee745c9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
|
Update:
From a code perspective is ready for review. |
alex-ju
changed the title
kr8n3r
reviewed
May 22, 2018
src/components/inset-text/README.md
Outdated
| @@ -0,0 +1,60 @@ | |||
| <script>document.body.className = ((document.body.className) ? document.body.className + ' js-enabled' : 'js-enabled');</script> | |||
kr8n3r
reviewed
May 22, 2018
src/components/inset-text/README.md
Outdated
| 1. [GOV.UK Frontend](/) | ||
| 2. Inset text | ||
|
|
||
| </div> |
There was a problem hiding this comment.
actually none of the divs in the readme
alex-ju
force-pushed
the
add-inset-text-component
branch
from
ee745c9 to
784f0d8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
|
@igloosi: good spot. was using the old |
kr8n3r
reviewed
May 22, 2018
|
|
||
| {{ govukInsetText({ | ||
| classes: '', | ||
| content: 'It can take up to 8 weeks <a href="#">to register</a> a lasting power of attorney if there are no mistakes in the application.' |
There was a problem hiding this comment.
this is 'html' or 'text' right, not 'content'?
alex-ju
force-pushed
the
add-inset-text-component
branch
from
784f0d8 to
a2c5029
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
kr8n3r
approved these changes
May 22, 2018
|
oh, changelog |
alex-ju
force-pushed
the
add-inset-text-component
branch
from
a2c5029 to
d14d43b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-709
NickColley
changed the title
NickColley
previously requested changes
May 22, 2018
|
📛 Call-out (text) |
alex-ju
changed the title
alex-ju
force-pushed
the
add-inset-text-component
branch
from
d14d43b to
7c613c4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inset text exists in GOV.UK Elements. We had originally decided not to reimplement it in GOV.UK Frontend as it was unclear that it was meeting user needs. However, during private beta it's become clear that inset text is needed.
Trello card