Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Design System url in package READMEs and review app #812

Merged
merged 3 commits into from
Jun 21, 2018
Merged

Fix Design System url in package READMEs and review app #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2329039
Update base Design System url in templates
Jun 21, 2018
9476691
Regenerate component README files
Jun 21, 2018
d42f3bf
Document in CHANGELOG
Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,8 @@

🏠 Internal:

- Pull Request Title goes here

Description goes here (optional)

([PR #N](https://github.com/alphagov/govuk-frontend/pull/N))
- Fix Design System url in package READMEs and review app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this is an internal change really, it does get published via npm but isn't run in our user's applications.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

([PR #812](https://github.com/alphagov/govuk-frontend/pull/812))

## 1.0.0 (Major release)

Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/component.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

{% set componentName = componentPath %}
{% set componentNameHuman = componentName | replace("-", " ") | capitalize %}
{% set componentGuidanceLink = componentGuidanceLink | default('https://govuk-design-system-production.cloudapps.digital/components/' + componentName)%}
{% set componentGuidanceLink = componentGuidanceLink | default('https://design-system.service.gov.uk/components/' + componentName)%}
{% set htmlMarkup %}
{% include componentName +"/"+ componentName +".njk" ignore missing %}
{% endset %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/readme.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% set nunjucksHtmlUsageMessage = '**If you’re using Nunjucks macros in production be aware that using `html` arguments, or ones ending with `Html` can be a [security risk](https://en.wikipedia.org/wiki/Cross-site_scripting). More about it in the [Nunjucks documentation](https://mozilla.github.io/nunjucks/api.html#user-defined-templates-warning).**' %}
{% set componentName = componentPath %}
{% set componentNameHuman = componentName | replace("-", " ") | capitalize %}
{% set componentGuidanceLink = componentGuidanceLink | default('https://govuk-design-system-production.cloudapps.digital/components/' + componentName)%}
{% set componentGuidanceLink = componentGuidanceLink | default('https://design-system.service.gov.uk/components/' + componentName)%}
<h1>
{% block componentName %}
{{ componentNameHuman }}
Expand Down
2 changes: 1 addition & 1 deletion src/components/back-link/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Link back component, to go back a page.

## Guidance

Find out when to use the Back link component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/back-link).
Find out when to use the Back link component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/back-link).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/breadcrumbs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The Breadcrumbs component helps users to understand where they are within a webs

## Guidance

Find out when to use the Breadcrumbs component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/breadcrumbs).
Find out when to use the Breadcrumbs component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/breadcrumbs).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/button/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A button is an element that allows users to carry out an action on a GOV.UK page

## Guidance

Find out when to use the Button component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/button).
Find out when to use the Button component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/button).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/checkboxes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Let users select one or more options.

## Guidance

Find out when to use the Checkboxes component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/checkboxes).
Find out when to use the Checkboxes component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/checkboxes).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/date-input/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A component for entering dates, for example - date of birth.

## Guidance

Find out when to use the Date input component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/date-input).
Find out when to use the Date input component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/date-input).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/details/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Component for conditionally revealing content, using the details HTML element.

## Guidance

Find out when to use the Details component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/details).
Find out when to use the Details component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/details).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/error-message/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Component to show a red error message - used for form validation. Use inside a l

## Guidance

Find out when to use the Error message component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/error-message).
Find out when to use the Error message component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/error-message).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/error-summary/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Component to show an error summary box - used at the top of the page, to summari

## Guidance

Find out when to use the Error summary component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/error-summary).
Find out when to use the Error summary component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/error-summary).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/fieldset/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The fieldset element is used to group several controls within a web form. The le

## Guidance

Find out when to use the Fieldset component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/fieldset).
Find out when to use the Fieldset component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/fieldset).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/file-upload/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The HTML `<input>` element with type="file" lets a user pick one or more files,

## Guidance

Find out when to use the File upload component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/file-upload).
Find out when to use the File upload component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/file-upload).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/footer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The footer component is used at the bottom of every GOV.UK page, to help users n

## Guidance

Find out when to use the Footer component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/footer).
Find out when to use the Footer component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/footer).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/header/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The header component is used at the top of every GOV.UK page, to help users navi

## Guidance

Find out when to use the Header component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/header).
Find out when to use the Header component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/header).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/panel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The confirmation panel has a turquoise background and white text. Used for trans

## Guidance

Find out when to use the Panel component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/panel).
Find out when to use the Panel component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/panel).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/phase-banner/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A banner that indicates content is in alpha or beta phase with a description.

## Guidance

Find out when to use the Phase banner component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/phase-banner).
Find out when to use the Phase banner component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/phase-banner).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/radios/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Let users select a single option from a list.

## Guidance

Find out when to use the Radios component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/radios).
Find out when to use the Radios component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/radios).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/select/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The HTML `<select>` element represents a control that provides a menu of options

## Guidance

Find out when to use the Select component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/select).
Find out when to use the Select component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/select).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/skip-link/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Skip link component. Make skip links visible when they are tabbed to. You'll nee

## Guidance

Find out when to use the Skip link component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/skip-link).
Find out when to use the Skip link component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/skip-link).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/table/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Table description.

## Guidance

Find out when to use the Table component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/table).
Find out when to use the Table component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/table).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/tabs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Component for conditionally revealing content, using tabs and tabs panels.

## Guidance

Find out when to use the Tabs component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/tabs).
Find out when to use the Tabs component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/tabs).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/tag/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Phase tags are mostly used inside phase banners as an indication of the state of

## Guidance

Find out when to use the Tag component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/tag).
Find out when to use the Tag component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/tag).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/textarea/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A multi-line text field.

## Guidance

Find out when to use the Textarea component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/textarea).
Find out when to use the Textarea component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/textarea).

## Quick start examples

Expand Down
2 changes: 1 addition & 1 deletion src/components/warning-text/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Use bold text with an exclamation icon if there are consequences - for example,

## Guidance

Find out when to use the Warning text component in your service in the [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital/components/warning-text).
Find out when to use the Warning text component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/warning-text).

## Quick start examples

Expand Down