Add border to warning text circle for overriden colours #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-852
36degrees
approved these changes
Jul 2, 2018
| padding-top: 3px; | ||
|
|
||
| border: 3px solid govuk-colour("black"); |
There was a problem hiding this comment.
Would be good to add a comment here to explain why using a border is beneficial – someone who's not thinking about the custom colours use case might well refactor this out.
|
Needs a changelog entry too. |
NickColley
force-pushed
the
make-warning-text-icon-better-when-overriden-colours
branch
from
ef0805b to
208d11f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-852
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-852
By adding a border to this component, when a user customises their colour settings they will still see a circle even if the background is removed.
NickColley
force-pushed
the
make-warning-text-icon-better-when-overriden-colours
branch
from
4f1cb18 to
402eb84
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-852
36degrees
approved these changes
Jul 4, 2018
NickColley
force-pushed
the
make-warning-text-icon-better-when-overriden-colours
branch
from
402eb84 to
5b0dfd0
Compare
NickColley
deleted the
make-warning-text-icon-better-when-overriden-colours
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a blog post on overriding classes I noticed this opportunity:
Before overriden colours
After overriden colours
Before regular colours
After regular colours