Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bottom margin on checkbox and radio labels #883

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Remove bottom margin on checkbox and radio labels #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff6c5d
Remove checkbox and radio label bottom margin
Jul 10, 2018
fb91063
Document in CHANGELOG
Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@

🔧 Fixes:

- Remove mistakenly applied 5px bottom margin from radio and checkbox
labels.
([PR #883](https://github.com/alphagov/govuk-frontend/pull/883))

- Apply `display:block` to `.govuk-main-wrapper`

In IE11 `main` element is set to `display:inline` so padding
Expand Down
1 change: 1 addition & 0 deletions src/components/checkboxes/_checkboxes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@

.govuk-checkboxes__label {
display: inline-block;
margin-bottom: 0;
padding: 8px $govuk-checkboxes-label-padding-left-right govuk-spacing(1);
cursor: pointer;
// remove 300ms pause on mobile
Expand Down
1 change: 1 addition & 0 deletions src/components/radios/_radios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@

.govuk-radios__label {
display: inline-block;
margin-bottom: 0;
padding: 8px $govuk-radios-label-padding-left-right govuk-spacing(1);
cursor: pointer;
// remove 300ms pause on mobile
Expand Down