Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panel title margin without body text #936

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Remove panel title margin without body text #936

merged 1 commit into from
Aug 3, 2018

Conversation

colinrotherham
Copy link
Contributor

This pull request patches the styling for govukPanel().

Currently:

  1. The element govuk-panel__body { text } is optional
  2. Margin is always applied to govuk-panel__title { titleText }

The title only needs a margin if the optional text is provided, otherwise vertical alignment is affected:

incorrect margin

Once patched, the margin will be optional 👍

@kr8n3r
Copy link

kr8n3r commented Aug 2, 2018

Hi @colinrotherham

this looks like a good tweak. We just need a second confirmation from the team

@36degrees 36degrees requested a review from dashouse August 2, 2018 15:51
@36degrees
Copy link
Contributor

I'd like to make sure @dashouse has the chance to review this.

Copy link

@dashouse dashouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks @colinrotherham

@kr8n3r kr8n3r added this to the [NEXT] milestone Aug 3, 2018
@kr8n3r kr8n3r merged commit e855c90 into alphagov:master Aug 3, 2018
@colinrotherham colinrotherham deleted the panel-text-margin branch August 7, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants