Turn off compatibility mode by default and turn on relative typography (rem) by default #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature will need to be enabled by users.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-981
NickColley
force-pushed
the
turn-on-responsive-typography-by-default
branch
from
e4359d0 to
a1970bb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-981
NickColley
force-pushed
the
turn-on-responsive-typography-by-default
branch
from
a1970bb to
cb477b4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-981
NickColley
changed the title
36degrees
reviewed
Sep 6, 2018
src/all.test.js
Outdated
| @@ -149,4 +149,21 @@ describe('GOV.UK Frontend', () => { | |||
|
|
|||
| expect(functionCalls).toBeNull() | |||
| }) | |||
| describe('responsive typography', async () => { | |||
| it('is enabled by default', async () => { | |||
There was a problem hiding this comment.
Rather than adding these, can we update the tests in src/helpers/typography.test.js? (We currently explicitly disable responsive mode, and then have a test for when it's enabled, but we should probably flip that logic?)
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-981
Ensures that new projects are using rem units for font sizes, which allows end-users to adjust their font-size. This is only enabled by default if the user is not using the compatibility mode variables.
Since it is now turned off by default, it needs documenting to explain how to turn it on.
NickColley
force-pushed
the
turn-on-responsive-typography-by-default
branch
from
a64e054 to
ec1377f
Compare
NickColley
commented
Sep 6, 2018
src/helpers/typography.test.js
Outdated
| $govuk-typography-use-rem: false; | ||
| ${sassBootstrap} |
There was a problem hiding this comment.
I have moved these around to better demonstrate how our users would write their SCSS
|
@36degrees updated the tests with your feedback |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #868
This pull request turns on relative typography by default unless the user has compatibility mode turned on.
It also turns off compatibility mode by default.
If a user wants to try relative typography in their application they can still do so.
We have just determined that we do not want to risk this by default since we can't be sure how the interface will behave with some elements resizing based on font size and some not.
I have tested this by confirming:
https://trello.com/c/8iqDncHe/1389-2-enable-rem-based-typography-by-default