Allow for custom ‘meta’ content in footer #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-990
This introduces an additional customisable ‘area’ in the footer where content can be added – a good example use case for this would be adding ‘Built by department name’.
|
Looks good to me :) |
36degrees
force-pushed
the
custom-footer-html
branch
from
8a5be4f to
c008d15
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces an additional customisable ‘area’ in the footer where content can be added – a good example use case for this would be adding ‘Built by department name’, or adding the Prototype Kit version.
Closes #956
Screenshots
Browser Testing
Desktop
Chrome 69 (macOS 10.13)
Edge 17 (Windows 10)
Firefox 61 (Windows 10)
Safari (macOS 10.13)
IE11 (Windows 7)
IE10 (Windows 7)
IE9 (Windows 7)
IE8 (Windows 7)
Mobile
Firefox 13 (iOS 11.4)
Google Chrome (Android 8)
Chrome 69 (iOS 11.4)
Safari (iOS 11.4)
Samsung Internet (Android 7)
https://trello.com/c/CdXqgVQg/1347-3-allow-additional-content-in-govukfooter-macro