Change as requested in review

alphagov · Apr 17, 2023 · 1bf1623 · 1bf1623
1 parent 49a7cf3
commit 1bf1623
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/manage-prototype-handlers.js b/lib/manage-prototype-handlers.js
@@ -219,8 +219,10 @@ function getTemplatesHandler (req, res) {
   const availableTemplates = getPluginTemplates()
 
   const commonTemplatesPackageName = '@govuk-prototype-kit/common-templates'
+  const govUkFrontendPackageName = 'govuk-frontend'
   let commonTemplatesDetails
-  if (!availableTemplates.some(plugin => plugin.packageName === commonTemplatesPackageName)) {
+  const installedPlugins = plugins.listInstalledPlugins()
+  if (installedPlugins.includes(govUkFrontendPackageName) && !installedPlugins.includes(commonTemplatesPackageName)) {
     commonTemplatesDetails = {
       pluginDisplayName: plugins.preparePackageNameForDisplay(commonTemplatesPackageName),
       installLink: `${contextPath}/plugins/install?package=${encodeURIComponent(commonTemplatesPackageName)}&returnTo=templates`

diff --git a/lib/manage-prototype-handlers.test.js b/lib/manage-prototype-handlers.test.js
@@ -200,6 +200,7 @@ describe('manage-prototype-handlers', () => {
         }
       }])
       plugins.preparePackageNameForDisplay.mockReturnValue(pluginDisplayName)
+      plugins.listInstalledPlugins.mockReturnValue([])
       nunjucksConfiguration.getNunjucksAppEnv.mockImplementation(() => ({
         render: () => view
       }))