Minor documentation update #160
Conversation
| @@ -20,7 +20,7 @@ Listening on port 3000 url: http://localhost:3000 | |||
|
|
|||
| ## Check it works | |||
|
|
|||
| In your web browser, visit [http://localhost:3000](http://localhost:3000) | |||
| In your web browser, visit <a href="http://localhost:3000" target="_blank">http://localhost:3000<span class="visuallyHidden"> (opens in a new window)</span></a> | |||
There was a problem hiding this comment.
don't think this needs a new window?
There was a problem hiding this comment.
I think it does. I observed a user yesterday follow the link from the docs, thereby loosing the documentation which has more to say - and in the future might have 'next steps'. Better to open in a new window IMHO.
There was a problem hiding this comment.
they didnt know to click back? I've seen more issues with people getting lost with new windows - you can't click back, theres no obvious thing to do to get back
There was a problem hiding this comment.
I think they're rather likely to want both open simultaneously. So they can play about with the kit whilst reading the docs.
These are also likely to be designers / people working on the kit - I am assuming that most of our users are likely to be able to handle different tabs, etc.
There was a problem hiding this comment.
ok, but I think the warning is useful to all users, not just screen readers. And should it be "opens in a new tab"?
edwardhorsford
force-pushed
the
docs-update
branch
from
a5790e5 to
a3d1714
Compare
|
@joelanman I've addressed your comments. |
Three minor corrections:
WARNs in npm install are ok.