Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page_scripts block #373

Merged
merged 1 commit into from
Apr 24, 2017
Merged

add page_scripts block #373

merged 1 commit into from
Apr 24, 2017

Conversation

joelanman
Copy link
Contributor

add page_scripts and scripts blocks - to allow people to add new scripts, or replace all scripts, on a per-page basis

add `page_scripts` and `scripts` blocks - to allow people to add new scripts, or replace all scripts, on a per-page basis
Copy link
Contributor

@paulmsmith paulmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this gets a big thumbs up from me. Small change but powerful one.

@htmlandbacon
Copy link
Contributor

Looks good to me 👍🏻

@joelanman joelanman merged commit 1816266 into master Apr 24, 2017
@joelanman
Copy link
Contributor Author

@paulmsmith @htmlandbacon thanks for checking this!

@joelanman joelanman deleted the script-blocks branch April 24, 2017 10:54
charlesrt pushed a commit to UKHomeOffice/home_office_design_kit that referenced this pull request Apr 24, 2017
# 5.1.1

- Update the alpha, beta and discovery colours to $govuk-blue to match
the updated phase banner ([PR
alphagov#370](alphagov/govuk_frontend_toolkit#370))
- Fix radio button show/hide behaviour when used outside a form ([PR
alphagov#375](alphagov/govuk_frontend_toolkit#375))
- Fix a "Stick at top when scrolling" component bug related to scroll
anchoring in Chrome 56+ ([PR
alphagov#376](alphagov/govuk_frontend_toolkit#376))
- Minor travis fixes ([PR
alphagov#373](alphagov/govuk_frontend_toolkit#373))

# 5.1.0

- Allow custom options when tracking events ([PR
alphagov#365](alphagov/govuk_frontend_toolkit#365))

# 5.0.3

- Change HMRC and DEFRA text colours for improved contrast ([PR
alphagov#368](alphagov/govuk_frontend_toolkit#368))
@edwardhorsford edwardhorsford mentioned this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants