-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaults file for auto store #475
Closed
mikeshawdev
wants to merge
14
commits into
alphagov:master
from
mikeshawdev:feature/add-defaults-file-for-auto-store
Closed
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6d8caaa
Add ability to load default values into sessions
330abba
Add explanatory comment to defaults file
c756dc3
Add try/catch around defaults loading code
0e04802
Fix linting error
69c7012
Rename defaults file for clarity
2444521
Create session defaults file if it doesn't exist
4781257
Add examples to session defaults file
43dc55c
Remove app session defaults file
2cd5216
Update examples in session defaults template file
ceaf811
Provide clearer error message for session defaults error
1be2e8d
Amend template session defaults file
e525357
Fix issue when creating session defaults file
01dee9c
Move session defaults require outside middleware
0141a88
Merge branch 'master' into feature/add-defaults-file-for-auto-store
joelanman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
|
||
Provide default values for user session data. These are automatically added | ||
via the `autoStoreData` middleware. Values will only be added to the | ||
session if a value doesn't already exist. This may be useful for testing | ||
journeys where users are returning or logging in to an existing application. | ||
|
||
============================================================================ | ||
|
||
Example usage: | ||
|
||
"full-name": "Sarah Philips", | ||
|
||
"options-chosen": [ "foo", "bar" ] | ||
|
||
============================================================================ | ||
|
||
*/ | ||
|
||
module.exports = { | ||
|
||
// Insert values here | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring the file can come out of the middleware, it only needs to happen once right?