Skip to content

Commit

Permalink
Merge pull request #349 from alphagov/upgrade-ruby-version
Browse files Browse the repository at this point in the history
Update minimum required Ruby version
  • Loading branch information
MuriloDalRi authored Feb 13, 2024
2 parents 3ab9754 + bcb1375 commit e1d631d
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
ruby: ['3.0', 3.1, 3.2]
ruby: [3.1, 3.2, 3.3]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.5
3.1.4
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Unreleased

* Drop support for Ruby 3.0. The minimum required Ruby version is now 3.1.4.
* Add support for Ruby 3.3.

# 9.8.2

* Fix Ruby 3.3 compatibility ([#343](https://github.com/alphagov/govuk_app_config/pull/343))
Expand Down
2 changes: 1 addition & 1 deletion govuk_app_config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/alphagov/govuk_app_config"
spec.license = "MIT"

spec.required_ruby_version = ">= 3.0"
spec.required_ruby_version = ">= 3.1.4"

spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
spec.bindir = "exe"
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/govuk_healthcheck/rails_cache_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

RSpec.describe GovukHealthcheck::RailsCache do
let(:cache) { double(:cache, write: true, read: true) }
let(:rails) { double(:mongoid, cache: cache) }
let(:rails) { double(:mongoid, cache:) }
before { stub_const("Rails", rails) }

describe ".status" do
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/govuk_healthcheck/sidekiq_redis_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

RSpec.describe GovukHealthcheck::SidekiqRedis do
let(:redis_info) { double(:redis_info) }
let(:sidekiq) { double(:sidekiq, redis_info: redis_info) }
let(:sidekiq) { double(:sidekiq, redis_info:) }
before { stub_const("Sidekiq", sidekiq) }

context "when the database is connected" do
Expand Down

0 comments on commit e1d631d

Please sign in to comment.