Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 9.9.1: don't send Sentry events on SignalException by default. #351

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Feb 13, 2024

These aren't very useful to have in Sentry and have been generating noise for those teams who choose to have all their Sentry events posted to Slack.

This stops e.g. rolling updates from spamming events into Sentry when every process receives a SIGTERM, like this.

These don't represent app issues so let's not log them to Sentry.

Some teams have all their Sentry events going to Slack and these have
been making the noise even worse than it need be.
@sengi sengi requested a review from ChrisBAshton February 13, 2024 15:21
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 👍

@sengi sengi merged commit f27c246 into main Feb 13, 2024
11 checks passed
@sengi sengi deleted the sengi/ignore-signalexception branch February 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants