Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons not checking when outer circle only is clicked #375

Closed
charlottewild opened this issue Dec 8, 2016 · 4 comments · Fixed by #406
Closed

Radio buttons not checking when outer circle only is clicked #375

charlottewild opened this issue Dec 8, 2016 · 4 comments · Fixed by #406

Comments

@charlottewild
Copy link

Case with two users who clicked the outer edge of the radio button, which activated the 'live' state of yellow but the radio button was not checked. User failed to notice.

How would you expect it to work?

Whole radio button should be clickable and instigate the radio button become active when clicked.

How does it work currently?

User can click the outer ring (quite common now they are larger) but the radio button does not become checked.

Feel free to suggest a fix...

Would suggest that should the outer ring be clicked, the radio button becomes checked without need for user to hit the middle of the target.

Caveat: this has only happened with two low-to-no users to date but thought I would share. Should it happen more, will update this ticket.

Explain the steps to reproduce the bug

  1. Use of radio buttons (new large format) in any question on Gov.uk website

Tell us about your environment

Radio buttons were being accessed in Google Chrome (unsure what version) on PC with Windows7 and being used on a GOV.uk prototype. No live example available.

@robinwhittleton
Copy link
Contributor

Thanks for the report! I’ve replicated something, but I want to check that it’s the same behaviour you’re seeing. I can get the focus ring to appear if I:

  1. hold the mouse button down while hovering over the outer ring
  2. mouse the cursor away from the radio
  3. release the mouse button

This adds the focus ring to the radio but doesn’t select it. Is this the behaviour you were seeing in the lab?

@charlottewild
Copy link
Author

Thanks Robin. Yes, that sounds very similar. I have video footage that I can slice down to show the specific issue. Can I add video content to this thread to you know?

@NickColley
Copy link
Contributor

That'd be really useful if you can manage it!

You could upload the clip to YouTube - as long as it does not have anything sensitive of course.

@charlottewild
Copy link
Author

Hi Nick, sorry for delay with this - was just wanting sign off from the Service Manager that she was happy for me to share. First clip is here - https://youtu.be/0LCF37YLgOw - am just editing the second down.

gemmaleigh added a commit that referenced this issue Feb 24, 2017
# 5.1.1

- Update the alpha, beta and discovery colours to $govuk-blue to match
the updated phase banner ([PR
#370](alphagov/govuk_frontend_toolkit#370))
- Fix radio button show/hide behaviour when used outside a form ([PR
#375](alphagov/govuk_frontend_toolkit#375))
- Fix a "Stick at top when scrolling" component bug related to scroll
anchoring in Chrome 56+ ([PR
#376](alphagov/govuk_frontend_toolkit#376))
- Minor travis fixes ([PR
#373](alphagov/govuk_frontend_toolkit#373))

# 5.1.0

- Allow custom options when tracking events ([PR
#365](alphagov/govuk_frontend_toolkit#365))

# 5.0.3

- Change HMRC and DEFRA text colours for improved contrast ([PR
#368](alphagov/govuk_frontend_toolkit#368))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants