Stop setting id on fieldsets

Now that the fieldset component uses the ComponentWrapperHelper, `id` should be handed by that instead of being explicitly called out.

This will result in `id` no longer being set on the fieldset, but instead on the parent. Jump links, the original usage for `id` will be unaffected, but any applications using `id` for other reasons (such as tests) may need to be updated.

CHANGELOG.md

@@ -7,6 +7,10 @@
   useful summary for people upgrading their application, not a replication
   of the commit log.
 
+## Unreleased
+
+* **BREAKING** Stop setting `id` on fieldsets ([PR #4454](https://github.com/alphagov/govuk_publishing_components/pull/4454))
+
 ## 45.10.0
 
 * Add 'toggle' module to each expandable region in metadata component ([PR #4397](https://github.com/alphagov/govuk_publishing_components/pull/4397))

app/views/govuk_publishing_components/components/_fieldset.html.erb

@@ -10,7 +10,6 @@
   heading_size = false unless shared_helper.valid_heading_size?(heading_size)
   error_message ||= nil
   error_id ||= nil
-  id ||= nil
 
   if error_message
     error_id = "error-#{SecureRandom.hex(4)}" unless error_id
@@ -27,7 +26,7 @@
   legend_classes << "govuk-fieldset__legend--#{heading_size}" if heading_size
 %>
 <%= tag.div(**component_helper.all_attributes) do %>
-  <%= tag.fieldset class: fieldset_classes, aria: { describedby: describedby }, role: role, id: id do %>
+  <%= tag.fieldset class: fieldset_classes, aria: { describedby: describedby }, role: role do %>
     <% if heading_level %>
       <%= tag.legend class: legend_classes do %>
         <%= content_tag(

spec/components/fieldset_spec.rb

@@ -21,16 +21,6 @@ def component_name
     assert_select ".gem-c-fieldset", text: /Lorem ipsum dolor sit amet, consectetur adipisicing elit. Vel ad neque, maxime est ea laudantium totam fuga!/
   end
 
-  it "renders a fieldset with an id" do
-    render_component(
-      legend_text: "Do you have a passport?",
-      id: "passports",
-      text: "Lorem ipsum dolor sit amet, consectetur adipisicing elit. Vel ad neque, maxime est ea laudantium totam fuga!",
-    )
-
-    assert_select ".govuk-fieldset#passports"
-  end
-
   it "renders a fieldset with the legend as heading" do
     render_component(
       legend_text: "Do you have a passport?",