-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant import in accordion component #1923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible. Can you record here specifically what it is that this component needs from component_support
?
All the |
This import resulted in an increase of our render-blocking resource
`components/print/accordion` requires `govuk-frontend` mixins as it imports the main `components/accordion` on line 5
74fd2b0
to
e8903fd
Compare
Ahh thanks for this @alex-ju! Do we want to use the |
Yes, we want to use |
## 24.1.1 * Fix deprecation warnings when running tests ([PR #1899](#1899)) * Update `govuk-frontend` base SCSS imports ([PR #1922](#1922)) * Remove redundant import in accordion component ([PR #1923](#1923)) * Fix toggle click tracking on step-by-steps ([PR #1925](#1925)) * Accordion summary design adjustment ([PR #1926](#1926)) * Fix `layout_header` layout and spacing issues ([PR #1924](#1924))
What
Remove redundant import in the accordion component that was accidentally introduced in #1884.
We do however need it for the print stylesheet, as we have two applications requiring the
components/print/accordion
but not thecomponent_support
. This could potentially be fixed in future by removingcomponent_support
fromprint/_accordion
and updating the suggested print imports to includecomponent_support
.Why
This import resulted in a considerable increase in our render-blocking resources.
Visual Changes
No visual changes