Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion summary design adjustment #1926

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

chris-gds
Copy link
Contributor

@chris-gds chris-gds commented Feb 12, 2021

What

Summary margin tweak on the accordion

Why

Design adjustment requested

Visual Changes

Screenshot 2021-02-12 at 17 24 13

Screenshot 2021-02-12 at 17 35 14

@chris-gds chris-gds requested a review from owenatgov February 12, 2021 16:36
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--xtase6 February 12, 2021 16:36 Inactive
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--xtase6 February 12, 2021 16:37 Inactive
Design tweak requested
Update


Update CHANGELOG
@chris-gds chris-gds force-pushed the accordion-margin-tweak branch from 599d6f6 to 72c327a Compare February 12, 2021 17:20
@bevanloon bevanloon temporarily deployed to govuk-publis-accordion--xtase6 February 12, 2021 17:20 Inactive
@chris-gds chris-gds marked this pull request as ready for review February 12, 2021 17:36
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@miaallers-zz
Copy link

miaallers-zz commented Feb 12, 2021

Looks good to me.

Background: deleting/ reducing the margin makes the title and description a more distinctive grouping.

@chris-gds chris-gds merged commit fdcf482 into master Feb 12, 2021
@chris-gds chris-gds deleted the accordion-margin-tweak branch February 12, 2021 18:02
@alex-ju alex-ju changed the title Adjust margin Accordion summary design adjustment Feb 12, 2021
alex-ju added a commit that referenced this pull request Feb 15, 2021
## 24.1.1

* Fix deprecation warnings when running tests ([PR #1899](#1899))
* Update `govuk-frontend` base SCSS imports ([PR #1922](#1922))
* Remove redundant import in accordion component ([PR #1923](#1923))
* Fix toggle click tracking on step-by-steps ([PR #1925](#1925))
* Accordion summary design adjustment ([PR #1926](#1926))
* Fix `layout_header` layout and spacing issues ([PR #1924](#1924))
@alex-ju alex-ju mentioned this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants