Fix toggle click tracking on step-by-steps #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1893 we added an SVG to the step by step navigation continuing to rely on the same logic for tracking, but the way the toggle click tracking script is designed expects the element triggering the click event to be an HTMLElement, not a path element, which causes a hard error and fails to send data to GA. With this change, we avoid capturing events at the SVG level, which means they will bubble and be captured by the parent HTMLElement.
owenatgov
approved these changes
Feb 12, 2021
alex-ju
added a commit
that referenced
this pull request
Feb 15, 2021
## 24.1.1 * Fix deprecation warnings when running tests ([PR #1899](#1899)) * Update `govuk-frontend` base SCSS imports ([PR #1922](#1922)) * Remove redundant import in accordion component ([PR #1923](#1923)) * Fix toggle click tracking on step-by-steps ([PR #1925](#1925)) * Accordion summary design adjustment ([PR #1926](#1926)) * Fix `layout_header` layout and spacing issues ([PR #1924](#1924))
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In #1893 we added an SVG to the step by step navigation continuing to rely on the same logic for tracking, but the way the toggle click tracking script is designed expects the element triggering the click event to be an HTMLElement, not a path element, which causes a hard error and fails to send data to GA. With this change, we avoid capturing events at the SVG level, which means they will bubble and be captured by the parent HTMLElement.
Why
Visual Changes
No visual changes
Example page: https://www.gov.uk/apply-transit-visa
No JavaScript errors