Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie banner preview in the component guide #1935

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Feb 16, 2021

What

Fix cookie banner preview in the component guide

Why

To be able to check the no-JS version. Fixes #1932.

Visual Changes

No visual changes (apart from it appearing in the component guide preview).

BeforeAfter
Screenshot 2021-02-16 at 13 05 58 Screenshot 2021-02-16 at 13 05 35

@alex-ju alex-ju merged commit 6b618ba into master Feb 16, 2021
@alex-ju alex-ju deleted the fix-cookie-banner-preview branch February 16, 2021 13:40
DilwoarH pushed a commit that referenced this pull request Feb 18, 2021
Includes:
* Fix cookie banner preview in the component guide ([PR #1935](#1935))
* Implements scroll tracking for the covid pages ([PR #1942](#1942))
@DilwoarH DilwoarH mentioned this pull request Feb 18, 2021
DilwoarH pushed a commit that referenced this pull request Feb 18, 2021
Includes:
* Fix cookie banner preview in the component guide ([PR #1935](#1935))
* Implements scroll tracking for the covid pages ([PR #1942](#1942))
DilwoarH pushed a commit that referenced this pull request Feb 18, 2021
Includes:
* Fix cookie banner preview in the component guide ([PR #1935](#1935))
* Implements scroll tracking for the covid pages ([PR #1942](#1942))
* Add anchor navigation feature to accordions ([PR #1937](#1937))
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies banner previews are broken with javascript disabled
2 participants