Add a Procfile so we can run as a govuk::app in puppet #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #publishing-frontend team want to be able to work on the gem without having to mount it into another Rails application first. We can use the dummy Rails app the test suite uses to achieve this.
NickColley
reviewed
Jan 3, 2018
| @@ -3,13 +3,6 @@ | |||
| describe 'Component guide index' do | |||
| # Load ordering test can only fail if run as the first test in suite | |||
| # https://github.com/rails/rails/issues/12168 | |||
| it 'renders using gem layout not app layout after viewing a page on the application' do | |||
There was a problem hiding this comment.
Is it a good idea to remove this test, do we need the redirect?
This test seems reasonable, making sure the gem doesnt accidentally force layout on other parts of the host app.
There was a problem hiding this comment.
Yeah, having looked again at the test, I agree. I've removed that commit.
This was referenced Jan 3, 2018
|
Is this also compatible with running on Heroku for review apps? That would be 🎆 |
|
We believe so, but will make any updates if needed to make that happen. |
NickColley
approved these changes
Jan 4, 2018
|
Aww |
|
I wonder if it's possible to tell heroku not to look at the top level directories? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/HSre7K10/453-style-the-mvp-email-collection-page-needed-by-jan
The #publishing-frontend team want to be able to work on the gem without
having to mount it into another Rails application first. We can use the
dummy Rails app the test suite uses to achieve this.
Other PR: alphagov/govuk-puppet#7014