Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove back-link enhancements #1550

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Jun 2, 2020

What

The code for new back-link is now in govuk-frontend and available to this gem so we can remove the local declarations.

Why

Keep codebase clean.

Visual Changes

BeforeAfter
Screenshot 2020-06-02 at 10 25 55 Screenshot 2020-06-02 at 10 25 42

This code is now available in govuk-frontend alphagov/govuk-frontend#1753
@alex-ju alex-ju requested a review from vanitabarrett June 2, 2020 09:30
@bevanloon bevanloon temporarily deployed to govuk-publis-remove-bac-z3n0nd June 2, 2020 09:30 Inactive
Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, Alex! 🎉

@alex-ju alex-ju merged commit d878801 into master Jun 2, 2020
@alex-ju alex-ju deleted the remove-back-link-enhancements branch June 2, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants