Update layout header component #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
layout_header_adjustments
branch
from
567460e to
bc09f96
Compare
alex-ju
approved these changes
Feb 4, 2021
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Outdated
Show resolved
Hide resolved
andysellick
approved these changes
Feb 4, 2021
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb
Show resolved
Hide resolved
danacotoran
force-pushed
the
layout_header_adjustments
branch
from
7c44411 to
e44b671
Compare
Add data attribute support on the layout header navigation links. The reason for this is because we are intending to use the layout header component for the transition checker nav whose links have data attributes for tracking. Another use for data attributes is for the Slimmer logic that hides/shows different links depending on the user's logged in status.
danacotoran
force-pushed
the
layout_header_adjustments
branch
from
e44b671 to
a19a279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add data attribute support on the layout header navigation links.
The reason for this is because we are intending to use the
layout_headercomponent for the transition checker nav whose links are cross-domain links and need data attributes for tracking.Why
During development the markup for the account nav (appears on the transition page, and transition checker) was copied over from the layout header component instead of using the component itself.
The component audits are now complaining that we are including the assets for
layout_headerinstatic, when we are not using the component.To fix this problem and reduce repetition, we are removing the hard coded account navigation from static, and using the layout header component in its place: alphagov/static#2408
Visual Changes
https://trello.com/c/9Kjy1hjb