-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacing to cookie banner confirmation message #1936
Conversation
341641b
to
036f326
Compare
@@ -39,6 +39,7 @@ $govuk-cookie-banner-background: govuk-colour("light-grey", "grey-4"); | |||
|
|||
.gem-c-cookie-banner__confirmation-message { | |||
margin-right: govuk-spacing(4); | |||
padding-top: govuk-spacing(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to have the padding on the overall component parent rather than add specific padding to child elements that does the same thing - although it looks like the problem here is the DS styles rather than yours.
I would remove the top padding from govuk-cookie-banner
and put it on gem-c-cookie-banner
instead, which would pad that and the confirmation message as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's messy with the required overrides, but I accept your point about applying it to the parent consistently - have updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that seems better to me. Unfortunately the spacing isn't consistent, due to a child of the confirmation message having padding of its own...
...but to be honest at this point if these are all DS styles then I think you've already done enough to try to make this consistent and any further discussion should happen at a different level, so I'm going to approve since you've already solved the problem you set out to solve.
036f326
to
f878e4f
Compare
f878e4f
to
770741d
Compare
770741d
to
e021619
Compare
What
Add spacing to cookie banner confirmation message
Why
It currently sits too close to the top of the browser
Visual Changes
Before
After