Tidy up untranslated content and formatting on accordion docs #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
from
50204e9 to
7e82b9c
Compare
injms
reviewed
Mar 15, 2021
app/assets/javascripts/govuk_publishing_components/components/accordion.js
Outdated
Show resolved
Hide resolved
injms
reviewed
Mar 15, 2021
app/assets/javascripts/govuk_publishing_components/components/accordion.js
Outdated
Show resolved
Hide resolved
injms
reviewed
Mar 15, 2021
injms
reviewed
Mar 15, 2021
app/views/govuk_publishing_components/components/_accordion.html.erb
Outdated
Show resolved
Hide resolved
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
2 times, most recently
from
750aa4a to
61e6907
Compare
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
4 times, most recently
from
bec3a08 to
3a30a7c
Compare
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
3 times, most recently
from
e23a2e5 to
656c716
Compare
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
from
656c716 to
f66551a
Compare
alex-ju
reviewed
Apr 12, 2021
owenatgov
force-pushed
the
tidy-up-translations-and-docs
branch
from
f66551a to
b606680
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
User facing: Moves some loose content into our translation file.
Docs facing: Tidies up some of the accordion documentation, specifically removing unnecessary quote marks on single line content.
Why
Principally best practice changes. Serving our content via translation files allows us to easily serve alternative content by locale in the event that it's required.
Addresses #1941 and @andysellick's comment on #1946
No visual changes.