Fix bug in summary list link text #1978
Merged
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
approved these changes
Mar 16, 2021
- link_text_no_enhance for row links was being checked against the overall links for the component - tests were not specific enough to spot this - now corrected
andysellick
force-pushed
the
fix-summary-list-bug
branch
from
786cff4 to
624ee5a
Compare
|
Whoops, meant to squash those commits. Done, thanks! |
Merged
This was referenced Mar 16, 2021
Merged
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
alex-ju
added a commit
that referenced
this pull request
Mar 19, 2021
* Add GOVUK Frontend Details module to GOVUK Modules and amend `modules.js` start function ([PR #1985](#1985)) * Rescope Brexit CTA to en/cy locale only ([PR #1984](#1984)) * Add JavaScript tests for accordion component ([PR #1977](#1977)) * Fix search component label background ([PR #1983](#1983)) * Allow emergency banner and global bar in public layout component ([PR #1978](#1915))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
link_text_no_enhancefor row links was being checked against the overall links for the component, so passing the parameter for the row when not passing it for the overall links had no effectWhy
It weren't working.
Visual Changes
None.