Re-work explicit-cross-domain-links.js
#2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
changed the title
explicit-cross-domain-links.js
danacotoran
force-pushed
the
explicit-x-domain-tracking-decorate-on-click
branch
from
96222e2 to
0d5341c
Compare
andysellick
approved these changes
Dec 9, 2021
| @@ -6,78 +6,79 @@ | |||
|
|
|||
| GOVUK.Modules.ExplicitCrossDomainLinks = function () { | |||
| this.start = function ($module) { | |||
There was a problem hiding this comment.
While you're at it... 😁
It seems like this module doesn't contain any jQuery, so you could switch it from using a start function to an init function. Shouldn't be a huge change - you'll need to change line 9 to this.element = $module and update how the code is called in the test, but that should be about it.
There was a problem hiding this comment.
Good suggestion, but do you mind if we do this as a separate piece of work as it's actually not so straightforward? Happy to record it as an issue in the meanwhile
app/assets/javascripts/govuk_publishing_components/analytics/explicit-cross-domain-links.js
Outdated
Show resolved
Hide resolved
danacotoran
force-pushed
the
explicit-x-domain-tracking-decorate-on-click
branch
from
0d5341c to
5e83b41
Compare
It has transpired that the explicit-cross-domain-links.js script was not set up correctly which is breaking our cross domain tracking currently. The source of the issue is the ga parameter which contains a timestamp which actually expires and becomes invalid after two minutes. The way the script worked previously was that the relevant cross-domain links and forms on the page were decorated with the _ga and cookie_consent parameters on page load. Doing it on page load is an issue due to the time-sensitive nature of the _ga parameter, as mentioned above. This changes the way the script works so that instead of decorating crossdomain links and forms with additional parameters on page load, we decorate them when they are interacted with. Besides ensuring that the _ga param is always valid and up-to-date, this also makes it so that there is no longer a need to listen for cookie banner events, so I also removed the cookie-reject event as part of this commit.
danacotoran
force-pushed
the
explicit-x-domain-tracking-decorate-on-click
branch
from
5e83b41 to
3684c2d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has transpired that the
explicit-cross-domain-links.jsscript was notset up correctly which is breaking our cross domain tracking currently.
The source of the issue is the
_gaparameter which contains a timestampwhich actually expires and becomes invalid after two minutes.
The way the script worked previously was that the relevant cross-domain
links and forms on the page were decorated with the
_gaandcookie_consentparameters on page load. Doing it on page load is anissue due to the time-sensitive nature of the
_gaparameter, asmentioned above.
This changes the way the script works so that instead of decorating
crossdomain links and forms with additional parameters on page load, we
decorate them when they are interacted with.
Besides ensuring that the
_gaparam is always valid and up-to-date, thisalso makes it so that there is no longer a need to listen for cookie
banner events, so I also removed the
cookie-rejectevent as part of thiscommit (this event was explicitly introduced for the
explicit-cross-domain-links.jsscript and is not used anywhere else currently).
https://trello.com/c/VaRq2typ/27-fix-cross-domain-issue