Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brexit call to action from contextual sidebar #2518

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented Dec 14, 2021

What

Remove the Brexit call to action from contextual sidebar

Why

Use of the link is dwindling and there are other pressing things that might need greater visibility.

Visual Changes

As expected, the element won't be rendered by the component anymore

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2518 December 14, 2021 14:44 Inactive
@sihugh sihugh changed the title Remove brexit sidebar [WIP] Remove Brexit sidebar Dec 14, 2021
@sihugh sihugh force-pushed the remove-brexit-sidebar branch from 205d0f0 to 376da5a Compare December 14, 2021 14:52
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2518 December 14, 2021 14:52 Inactive
sihugh and others added 2 commits March 4, 2022 14:56
The Brexit sidebar call to action is no longer required as the checker has been retired. Research shows that users are looking for how to do specific things now rather than starting on Brexit and working in from there.
@alex-ju alex-ju force-pushed the remove-brexit-sidebar branch from 376da5a to a197310 Compare March 4, 2022 14:57
@alex-ju alex-ju changed the title [WIP] Remove Brexit sidebar Remove Brexit call to action from contextual sidebar Mar 4, 2022
@alex-ju alex-ju marked this pull request as ready for review March 4, 2022 15:03
@alex-ju alex-ju requested a review from hannako March 4, 2022 15:05
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few references to transition-check in the translation files. Which seems weird as that's been retired and the url is redirected to the brexit landing page. But I'll sort that in a separate PR, as it's unrelated to this.

This looks good to me 🥳

false
end

def parent_taxon_include?(taxon, taxon_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit sad to lose this lovely recursive method!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too, might actually be the last one in this repo 😢

@alex-ju alex-ju merged commit 696175d into master Mar 4, 2022
@alex-ju alex-ju deleted the remove-brexit-sidebar branch March 4, 2022 15:28
hannako added a commit that referenced this pull request Mar 7, 2022
* Update the list of popular links in the super navigation header ([#2660](#2660))
* Remove Brexit call to action from contextual sidebar ([#2518](#2518))
@hannako hannako mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants