Fix underline on organisation logo component #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
fix-org-logo
branch
from
1468293 to
f96885d
Compare
MartinJJones
approved these changes
Sep 9, 2022
NickColley
reviewed
Sep 9, 2022
Sorry @NickColley, can you clarify? I've removed the relative positioning. |
chao-xian
approved these changes
Sep 9, 2022
|
Ah yeah, I missed that in the diff, nice fix. sorry for the confusion |
This was referenced Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the underline on the organisation logo component.
Why
This appears to be being caused by a bug in Chromium related to the use of
position: relativeandtop: 3px- the underline on the element is not adjusted, meaning that the text is pushed down 3px, slightly overlapping the underline (if you increase the value fortopyou can make the underline eventually appear above the text).The bug has only been recently reported but we don't really need to have this CSS on this element - the same effect can be achieved by increasing the padding above the element by 3px.
Visual Changes
Tested in various Chromes and Chrome on mobile.