-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 8.0.0 #311
Version 8.0.0 #311
Conversation
Is there a chance we can wait until #310 is in? |
@thomasleese probably, how long do you think it'll be before it's ready? |
@andysellick should be pretty soon, it's ready for review now. |
@thomasleese @tijmenb has approved it, but apparently the contextual breadcrumb component is still using the breadcrumb component from static (or something like that) so we should look into that for this release as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest breadcrumb change is broken. There are stray %>
https://govuk-publishing-components.herokuapp.com/component-guide/breadcrumbs
D'oh! Also I think this is the thing @tijmenb is referring to... https://github.com/alphagov/govuk_publishing_components/blob/master/app/views/govuk_publishing_components/components/_contextual_breadcrumbs.html.erb |
Does #313 cover that? |
@vanitabarrett @thomasleese I'm fixing the stray Ah yes, #312 already covers the stray %>, great. Have just approved, can you merge and I'll rebase this? @thomasleese if you can get the tests passing on #313 I'll happily approve it. |
1991e4b
to
d4e1908
Compare
d4e1908
to
c9517ff
Compare
Includes the following. Changes to the heading component are breaking (about to create a PR on government-frontend to account for that)