Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 8.0.0 #311

Merged
merged 1 commit into from
May 15, 2018
Merged

Version 8.0.0 #311

merged 1 commit into from
May 15, 2018

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented May 15, 2018

Includes the following. Changes to the heading component are breaking (about to create a PR on government-frontend to account for that)

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-311 May 15, 2018 11:06 Inactive
@thomasleese
Copy link
Contributor

Is there a chance we can wait until #310 is in?

@andysellick
Copy link
Contributor Author

@thomasleese probably, how long do you think it'll be before it's ready?

@thomasleese
Copy link
Contributor

@andysellick should be pretty soon, it's ready for review now.

@andysellick
Copy link
Contributor Author

@thomasleese @tijmenb has approved it, but apparently the contextual breadcrumb component is still using the breadcrumb component from static (or something like that) so we should look into that for this release as well.

Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest breadcrumb change is broken. There are stray %> https://govuk-publishing-components.herokuapp.com/component-guide/breadcrumbs

@andysellick
Copy link
Contributor Author

@thomasleese
Copy link
Contributor

Does #313 cover that?

@andysellick
Copy link
Contributor Author

andysellick commented May 15, 2018

@vanitabarrett @thomasleese I'm fixing the stray %>

Ah yes, #312 already covers the stray %>, great. Have just approved, can you merge and I'll rebase this?

@thomasleese if you can get the tests passing on #313 I'll happily approve it.

@thomasleese thomasleese dismissed vanitabarrett’s stale review May 15, 2018 12:26

Stray <% addressed in #312

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-311 May 15, 2018 12:27 Inactive
@andysellick andysellick merged commit 5bb7f20 into master May 15, 2018
@andysellick andysellick deleted the update-gem-8.0.0 branch May 15, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants