Add Welsh translation for all_opens_in_new_tab
#3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
add-welsh-all-tab
branch
from
719ffac to
45977eb
Compare
brucebolt
force-pushed
the
add-welsh-all-tab
branch
from
45977eb to
fd86e85
Compare
andysellick
approved these changes
May 2, 2023
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| * Make Cookie Banner Implementation More Like Design System Implementation [(PR #3325)](https://github.com/alphagov/govuk_publishing_components/pull/3325) | |||
| * Remove capitalisation on GA4 action property value [PR #3367](https://github.com/alphagov/govuk_publishing_components/pull/3367) | |||
| * Add Welsh translation for "Sharing will open the page in a new tab" ([PR #3370](https://github.com/alphagov/govuk_publishing_components/pull/3370)) | |||
There was a problem hiding this comment.
Nitpick: can this match the PR title?
There was a problem hiding this comment.
Actually not sure this warrants a changelog entry, it's such a small thing. Maybe just remove this?
There was a problem hiding this comment.
I'll update it to match the title, as it does ever so slightly change the user facing output.
This was showing English text on a Welsh language page. Zendesk ticket: https://govuk.zendesk.com/agent/tickets/5318644
brucebolt
force-pushed
the
add-welsh-all-tab
branch
from
fd86e85 to
1d3b6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the Welsh translation for "Sharing will open the page in a new tab".
Why
A department (DVLA) have noticed the text is in the wrong language on their Welsh organisation page and on their Welsh news stories.
Zendesk ticket: https://govuk.zendesk.com/agent/tickets/5318644