-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA4 video tracking #3535
Merged
Merged
Add GA4 video tracking #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 2, 2023 14:13
672c082
to
13fd9bb
Compare
andysellick
changed the title
[DO NOT MERGE] Add GA4 video tracking
Add GA4 video tracking
Aug 2, 2023
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 2, 2023 14:52
13fd9bb
to
9893598
Compare
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 2, 2023 14:53
9893598
to
b582eca
Compare
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 3, 2023 16:41
b582eca
to
ecf6651
Compare
@JamesCGDS hold off on review for now, that problem we discovered is going to require a bit of rework, but I think the solution we came up with will work. |
andysellick
changed the title
Add GA4 video tracking
[DO NOT MERGE] Add GA4 video tracking
Aug 3, 2023
andysellick
changed the title
[DO NOT MERGE] Add GA4 video tracking
Add GA4 video tracking
Aug 8, 2023
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 9, 2023 09:12
cc96bfb
to
c64706b
Compare
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 11, 2023 07:35
c64706b
to
93ec7fd
Compare
JamesCGDS
reviewed
Aug 11, 2023
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 11, 2023 14:37
93ec7fd
to
febe1a0
Compare
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 11, 2023 15:46
febe1a0
to
387b847
Compare
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 11, 2023 15:48
387b847
to
48cbdd8
Compare
- add new attributes for video tracking
- add docs for video tracker - update changelog
andysellick
force-pushed
the
ga4-video-tracking
branch
from
August 11, 2023 15:52
48cbdd8
to
f71adf4
Compare
JamesCGDS
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds tracking for Youtube videos for GA4. See included documentation for details.
Why
Part of the GA4 migration.
Visual Changes
None.
Trello card: https://trello.com/c/zQiODIUm/607-investigate-how-ga4-tracking-will-work-for-video