Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 video tracking #3535

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Add GA4 video tracking #3535

merged 3 commits into from
Aug 11, 2023

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Aug 1, 2023

What

Adds tracking for Youtube videos for GA4. See included documentation for details.

Why

Part of the GA4 migration.

Visual Changes

None.

Trello card: https://trello.com/c/zQiODIUm/607-investigate-how-ga4-tracking-will-work-for-video

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 1, 2023 15:49 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 2, 2023 14:08 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 2, 2023 14:13 Inactive
@andysellick andysellick changed the title [DO NOT MERGE] Add GA4 video tracking Add GA4 video tracking Aug 2, 2023
@andysellick andysellick marked this pull request as ready for review August 2, 2023 14:52
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 2, 2023 14:52 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 2, 2023 14:53 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 3, 2023 16:41 Inactive
@andysellick
Copy link
Contributor Author

@JamesCGDS hold off on review for now, that problem we discovered is going to require a bit of rework, but I think the solution we came up with will work.

@andysellick andysellick changed the title Add GA4 video tracking [DO NOT MERGE] Add GA4 video tracking Aug 3, 2023
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 4, 2023 09:35 Inactive
@andysellick andysellick changed the title [DO NOT MERGE] Add GA4 video tracking Add GA4 video tracking Aug 8, 2023
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 9, 2023 09:13 Inactive
@andysellick andysellick requested a review from JamesCGDS August 9, 2023 13:37
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 11, 2023 07:35 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 11, 2023 14:38 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 11, 2023 15:46 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 11, 2023 15:49 Inactive
- add new attributes for video tracking
- add docs for video tracker
- update changelog
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3535 August 11, 2023 15:52 Inactive
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🚀

@andysellick andysellick merged commit 3659c8c into main Aug 11, 2023
@andysellick andysellick deleted the ga4-video-tracking branch August 11, 2023 15:57
@andysellick andysellick mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants