Add the hidden attribute to mobile menu button #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
add-hidden-attribute-to-mobile-menu-button
branch
from
ce9cfc7 to
5d80fd8
Compare
andysellick
approved these changes
Apr 11, 2024
- Add the hidden attribute to mobile menu button - Update the layout header spec to check for the presence of the hidden attribute on the mobile menu button - Update CHANGELOG.md
MartinJJones
force-pushed
the
add-hidden-attribute-to-mobile-menu-button
branch
from
5d80fd8 to
27b9003
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the
hiddenattribute to the mobile menu button in the layout_header componentWhy
In preparation for upgrading to version 5 of govuk-frontend.
Adding the
hiddenattribute to the mobile menu button was a recommend change in the release of 4.3 of govuk-frontend - https://github.com/alphagov/govuk-frontend/releases/tag/v4.3.0In version 5 of govuk-frontend, the
hiddenattribute is required to ensure that the menu button remains hidden when JavaScript is disabled:govuk-header__menu-buttongovuk-frontend#3596Trello card