Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused org colour classes #4173

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Remove unused org colour classes #4173

merged 1 commit into from
Aug 27, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Aug 23, 2024

What / Why

  • Removes a couple org colours from our _brand-colours SASS file.
  • The ministry-of-housing-communities-and-local-government class existed as a way to add the brand colour before govuk-frontend added it
  • We added department-for-business-and-trade as the class in govuk-frontend was renamed to department-for-business-trade, so to stop the brand colours disappearing when govuk-frontend was deployed, we added them here.
  • These organisations do not use these class names anymore as well, so they're safe to remove from the gem: https://github.com/alphagov/whitehall/pull/9379/files

Visual Changes

None.

@AshGDS AshGDS self-assigned this Aug 23, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4173 August 23, 2024 14:55 Inactive
@AshGDS AshGDS force-pushed the remove-org-colours branch from 5226496 to 3d29c3f Compare August 23, 2024 15:00
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4173 August 23, 2024 15:00 Inactive
@AshGDS AshGDS requested a review from matthillco August 23, 2024 15:04
They are no longer used since the govuk-frontend v5.5 release, as govuk-frontend contains their brand colours now.
@AshGDS AshGDS force-pushed the remove-org-colours branch from 3d29c3f to 925cdb0 Compare August 27, 2024 07:28
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4173 August 27, 2024 07:28 Inactive
@AshGDS AshGDS merged commit 2a2e5a1 into main Aug 27, 2024
12 checks passed
@AshGDS AshGDS deleted the remove-org-colours branch August 27, 2024 07:51
@AshGDS AshGDS mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants