Improve print styles for inverse-header component #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
print-styles-inverse-header
branch
from
e4323bc to
336b2a8
Compare
matthillco
force-pushed
the
print-styles-inverse-header
branch
from
336b2a8 to
9be12e7
Compare
matthillco
changed the title
AshGDS
reviewed
Sep 2, 2024
It's been reviewed by Nikin and we've kept some of that internal top and bottom padding as it allows breathing space between elements of the page. If the padding is reduced too much, the design suffers and becomes harder to scan. |
AshGDS
approved these changes
Sep 2, 2024
matthillco
force-pushed
the
print-styles-inverse-header
branch
from
eb251ae to
39a0382
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This improves the print styles for the
inverse-headercomponent as part of the work to improve print styles for page layouts:Trello
Why
Although we made improvements to this component as part of #4073, we did not look at how the component might interact with other components on the page. This PR further improves the component in context of page types.
Visual Changes
Before and After: Component Preview
Before and After: Component on a HTML Publication page