New class to collapse columns for print #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
changed the title
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
1bf6a46
to
cb69ef6
Compare
matthillco
changed the title
AshGDS
approved these changes
Sep 17, 2024
andysellick
reviewed
Sep 17, 2024
app/assets/stylesheets/govuk_publishing_components/lib/print_support.scss
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
cb69ef6
to
853efe7
Compare
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
853efe7
to
2b62a74
Compare
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
2b62a74
to
ec60adc
Compare
andysellick
reviewed
Sep 18, 2024
app/assets/stylesheets/govuk_publishing_components/component_support.scss
Show resolved
Hide resolved
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
ec60adc
to
e0ea974
Compare
matthillco
force-pushed
the
spike-collapse-grid-for-print
branch
from
e0ea974
to
fb67deb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Provide a new helper class to "collapse" row/column layouts when printing. This class forces all floated columns in the associated row to print at full page width. Trello
Why
When printing various page types, the 2/3rds + 1/3rds column layout causes issues with cropped content and a generally poor printing experience because the full page isn't used. By selectively collapsing floated columns, we can avoid most of these issues and improve the printing experience by using the full width of the page.
Before/After page type: GUIDE
Before/After page type: DETAILED_GUIDE
Before/After page type: HTML_PUBLICATION (Portrait, no change}
Before/After page type: HTML_PUBLICATION (Landscape}