Make deploying meta tags changes easier #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
just-in-case
branch
from
4195808
to
197765c
Compare
AshGDS
requested changes
Sep 18, 2024
app/assets/javascripts/govuk_publishing_components/analytics-ga4/ga4-page-views.js
Outdated
Show resolved
Hide resolved
andysellick
force-pushed
the
just-in-case
branch
from
197765c
to
aabb543
Compare
AshGDS
approved these changes
Sep 18, 2024
- recently updated the names of some of the metatags that GA4 reads for page views - but it's possible that the changes to those metatags won't be appearing for a while on a lot of pages, as they probably need republishing first - so for now let's read either the new or the old metatag (which will contain the same information) and avoid breaking a part of the GA4 tracking - haven't done the same for the strip dates/postcodes/etc. metatags as I think they're all handled internal to the gem - follow up to changes made in #4222
andysellick
force-pushed
the
just-in-case
branch
from
aabb543
to
40a88ff
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Visual Changes
None.