Update Govspeak "Warning Text" component styles #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
update-govspeak-warning-text-styles
branch
from
e7163f4 to
118eeb8
Compare
andysellick
reviewed
Jan 16, 2025
app/assets/stylesheets/govuk_publishing_components/components/govspeak/_warning-callout.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/govspeak/_warning-callout.scss
Outdated
Show resolved
Hide resolved
jon-kirwan
force-pushed
the
update-govspeak-warning-text-styles
branch
from
118eeb8 to
8988548
Compare
jon-kirwan
force-pushed
the
update-govspeak-warning-text-styles
branch
from
8988548 to
78a1efd
Compare
andysellick
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update Govspeak "Warning Text" component styles to extend the GOV.UK Frontend
govuk-warning-text__iconstyles.See https://components-gem-pr-4487.herokuapp.com/component-guide/govspeak/warning_callout/preview
Why
The left spacing between the icon and text appears to be excessive compared to both the Warning Text component and its Design System equivalent
Visual Changes
Before (mobile)
After (mobile)
Before (tablet)
After (tablet)
Before (travel advice page - mobile)
After (travel advice page - mobile)
Before (travel advice page - tablet)
After (travel advice page - tablet)