[DO NOT MERGE] Refactor single page notification component #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
single-rework
branch
from
3e00b03 to
ebc1d8f
Compare
- move most of the component attributes (class, data attributes) to be handled by the component wrapper on the parent element - update the helper and tests to reflect this change
andysellick
force-pushed
the
single-rework
branch
from
ebc1d8f to
0a62225
Compare
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor the markup of the single page notification button component slightly...
I've tested this with a branch on integration for https://www.gov.uk/guidance/check-if-an-email-youve-received-from-hmrc-is-genuine and it seems to behave as it did before, but I've left the commit in this PR for testing a branch in case anyone wants to test it for themselves.
Why
This component was inconsistent because it was using the component wrapper helper but had its parent class (
gem-c-single-page-notification-button) on a child element, rather than the parent. There seems to be no need for this, but it was causing a problem in some unrelated work, so thought I'd fix it.Visual Changes
None, hopefully.