[WIP] Recreate global bar component from static app #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
move-global-bar-from-static
branch
from
bac56c8 to
7989d31
Compare
The hardcoded text in the view can now be passed as parameters from the instance of the component. The `link_text` code is now removed as it was previously hardcoded to false (it's not required).
matthillco
force-pushed
the
move-global-bar-from-static
branch
from
57797a5 to
24fe024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Copy the
global-barcomponent from the static app as the initial step in removing it from static.Trello
Why
The static app will be retired, but the
global-barcomponent will still be needed.