Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant role attributes from elements #4556

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Jan 15, 2025

What

Remove redundant role attributes from components.

Why

From GOV.UK Frontend:

We've made minor changes to the HTML of the page template, as well as the header, footer and pagination components.

You can update your HTML to remove the role attribute from some elements. These include the:

main role on the main element in the template
banner role on the header element in the Header component
contentinfo role on the footer element in the Footer component
navigation role on the nav element in the Pagination component

These roles were present to support legacy browsers, such as older versions of Internet Explorer. GOV.UK Frontend no longer supports these browsers, so you can now remove these roles.

This change was introduced in alphagov/govuk-frontend#4854.

See https://github.com/alphagov/govuk-frontend/releases/tag/v5.3.0

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4556 January 15, 2025 16:25 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4556 January 15, 2025 16:29 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review January 15, 2025 16:38
@jon-kirwan jon-kirwan merged commit 0612a47 into main Jan 16, 2025
12 checks passed
@jon-kirwan jon-kirwan deleted the remove-redundant-roles branch January 16, 2025 10:19
@AshGDS AshGDS mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants