Create shared helper for components #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
652e13b to
ed518c2
Compare
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
ed518c2 to
b78e24c
Compare
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
b78e24c to
445d188
Compare
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
70ec4d0 to
0866905
Compare
andysellick
changed the title
alex-ju
reviewed
Feb 25, 2019
There was a problem hiding this comment.
Thanks for working on this @andysellick.
I left a few comments, otherwise looks great. And I'm not sure about the name shared_helper, but I guess makes its purpose clear and it's something we can change if we feel like.
app/assets/stylesheets/govuk_publishing_components/components/_textarea.scss
Show resolved
Hide resolved
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
207f026 to
de41373
Compare
|
@alex-ju thanks for the comments. Yeah, I struggled with the name a bit. I went with that because it was the clearest and shortest thing I could think of. Happy to change it later if we can think of something better. |
alex-ju
approved these changes
Feb 26, 2019
- provides margin bottom for components
- for margin bottom
- restructure textarea slightly to put margin on wrapping element rather than textarea itself, as those two margins were conflicting - set default margin to be 6, overriding default of 3 in shared helper, means this will be a non-breaking change - add margin option to documentation
- defaults to no margin as per original behaviour
- update shared helper to return a span if heading level 0 is passed, instead of a heading level - retain the default of h2 if nothing or an invalid value is passed
andysellick
force-pushed
the
create-shared-helper-for-components
branch
from
de41373 to
78bad64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of the components are now using the same or similar code for setting a margin bottom and creating a heading level. This PR creates a single shared component helper that provides that functionality in one place, and updates those components that need it to use it.
Trello card: https://trello.com/c/DCHfrY2s/82-draft-create-a-shared-set-of-helper-functions-to-be-used-across-components