Add a margin_bottom option to details component #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Feb 26, 2019
|
@andysellick yep, that would be great. we need it this sprint so there's not much rush with it. I'll add a DNM and wait to rebase. |
alex-ju
changed the title
|
@alex-ju have merged the shared helper so you can use it here now. |
alex-ju
force-pushed
the
add-margin-to-details
branch
from
c0ae532 to
1cf5516
Compare
alex-ju
changed the title
|
@andysellick updated to use the shared helper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom margin to the details component.