Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated favicon icons to remove invalid html and modernise #300

Merged
merged 1 commit into from
May 15, 2017
Merged

Updated favicon icons to remove invalid html and modernise #300

merged 1 commit into from
May 15, 2017

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented May 12, 2017 •
edited
Loading

Updates apple touch icon sizes and syntax that follow Apple spec
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
and
https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/

This also makes html valid according to W3C

W3C validator before
screen shot 2017-05-12 at 10 59 31

W3C validator after
screen shot 2017-05-12 at 11 25 47

Note: tested by manual upload of the current gov.uk source and replaced declaration

@NickColley
Copy link
Contributor

Nice! @igloosi can you show how you've tested this?

@kr8n3r
Copy link
Author

kr8n3r commented May 12, 2017

screenshots attached

@NickColley
Copy link
Contributor

NickColley commented May 12, 2017 •
edited
Loading

Sorry I was super unclear :P I was thinking how the icons render on devices?

@kr8n3r
Copy link
Author

kr8n3r commented May 12, 2017 •
edited
Loading

oh that. would need to build this branch somewhere i guess. and have devices to test on, like a Device Lab

@kr8n3r
Copy link
Author

kr8n3r commented May 15, 2017

after a long, needlessly complicated procedure to get template up and running, here are screeshots from browserstack device emulator
screen shot 2017-05-12 at 16 58 07
screen shot 2017-05-12 at 17 01 45

@36degrees
Copy link
Contributor

For the curious, the -precomposed suffix used to instruct iOS not to add effects (drop shadow and 'a reflective shine')

As of iOS 7, no special effects are applied to touch icons anymore, so if you only care about iOS 7 and up you don’t have to use precomposed anymore.
– https://mathiasbynens.be/notes/touch-icons

IMO that's fine.

@kr8n3r
Copy link
Author

kr8n3r commented May 15, 2017

yeah, ios 7 is ancient :)

@kr8n3r kr8n3r merged commit 82d9459 into master May 15, 2017
@kr8n3r kr8n3r deleted the apple-touch-icons branch May 15, 2017 08:46
@kr8n3r kr8n3r mentioned this pull request May 15, 2017
Merged
@fofr
Copy link
Contributor

fofr commented May 16, 2017

This has had an interesting (and unexpected) affect on Static:
alphagov/static#1041

@gemmaleigh gemmaleigh mentioned this pull request Jun 8, 2017
Closed
gemmaleigh pushed a commit to alphagov/govuk_elements that referenced this pull request Jun 8, 2017
@greenkeeper @gemmaleigh
fix(package): update govuk_template_jinja to version 0.20.1
b339bc9 
0.20.1
- Fix invalid html from Apple touch icons syntax [PR #300](alphagov/govuk_template#300) and
update icon sizes to match Apple specs
@gemmaleigh gemmaleigh mentioned this pull request Jun 8, 2017
Merged
@gemmaleigh gemmaleigh mentioned this pull request Jun 16, 2017
Merged
@colinrotherham colinrotherham mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kr8n3r @NickColley @36degrees @fofr