Replace Alpine for Debian in our Dockerfile #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Alpine docker image has a smaller stack size which results in SystemStackError from being raised in situations where you have a deep call stack. This error was being raised in this repository when running Capybara tests involving rack-test and SASS compilation. Switching to Debian should fix this as it doesn't have this stack size problem. See more information on this issue here: docker-library/ruby#196 When switching to Debian, we're pulling in the yarn binary via their apt repository as default Debian doesn't provide an npm from which we could use `npm install -g yarn`. An additional problem is that the default Debian install doesn't support apt repositories on HTTPS urls. We first have to install the `apt-transport-https` before being able to use the yarn repo.
adrianclay
force-pushed
the
use-debian-dockerimage
branch
from
339d2e1
to
4657795
Compare
tommotaylor
approved these changes
Aug 9, 2018
|
Looks good and works for me @adrianclay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alpine docker image has a smaller stack size which results in
SystemStackError from being raised in situations where you have a
deep call stack.
This error was being raised in this repository when running
Capybara tests involving rack-test and SASS compilation.
Switching to Debian should fix this as it doesn't have this stack
size problem.
See more information on this issue here:
docker-library/ruby#196
When switching to Debian, we're pulling in the yarn binary via
their apt repository as default Debian doesn't provide an npm
from which we could use
npm install -g yarn.An additional problem is that the default Debian install doesn't
support apt repositories on HTTPS urls. We first have to install
the
apt-transport-httpsbefore being able to use the yarn repo.