This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
Add contract tests #143
Merged
Add contract tests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiecobbett
force-pushed
the
add_contract_tests
branch
5 times, most recently
from
8cd664e to
f1062ef
Compare
| @@ -159,4 +159,38 @@ | |||
| expect(page.status_code).to eq(200) | |||
| end | |||
| end | |||
|
|
|||
| describe "support for example manuals in govuk-content-schemas" do | |||
| it 'should render a vaguely correct page' do | |||
There was a problem hiding this comment.
The description probably needs to be a bit less, well, vague. 'should render a page containing the title'?
There was a problem hiding this comment.
Agreed - rebased.
Testing this way means that as examples are added, running these tests will automatically test the app against them. Ideally we'd have more in-depth tests using the example(s), but this would duplicate the existing tests.
Different contract tests will be needed for hmrc_manuals and hmrc_manual_sections.
jamiecobbett
force-pushed
the
add_contract_tests
branch
from
f1062ef to
2baed38
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.